PS-441 fix for phase predecessor calculations on update #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| timelineTemplateId | ||
| ); | ||
| const { phaseDefinitionMap } = await this.getPhaseDefinitionsAndMap(); | ||
| const challengePhaseIds = new Set(_.map(challengePhases, "phaseId")); |
There was a problem hiding this comment.
[💡 performance]
Using _.map to create a Set of phaseIds is efficient for lookups, but ensure that challengePhases is not excessively large, as this could impact performance. Consider profiling if performance issues arise.
| const predecessorPhase = _.find(updatedPhases, { | ||
| phaseId: phase.predecessor, | ||
| }); | ||
| if (_.isNil(predecessorPhase)) { |
There was a problem hiding this comment.
[correctness]
The check for _.isNil(predecessorPhase) and subsequent continue statement ensures that phases without valid predecessors are skipped. However, this could potentially hide logical errors if a phase is expected to have a predecessor. Consider logging or handling this scenario explicitly if it's not expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PS-441